Skip to content

Fixed link not dispalyed in markup in Style.cs and added unit test cases #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

Fixed link not dispalyed in markup in Style.cs and added unit test cases #1750

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d646f0
Fixed link not dispalyed in markup in Style.cs and added unit test cases
Elementttto Feb 1, 2025
ebd8884
- Addressed review comments
Elementttto Jun 2, 2025
69b1e9e
Merge branch 'spectreconsole:main' into Bug-Fix-#1642
Elementttto Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Spectre.Console/Style.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,11 @@ public string ToMarkup()
builder.Add("on " + Background.ToMarkup());
}

if (Link?.ToString() != null)
{
builder.Add($"link={Link.ToString()}");
}

return string.Join(" ", builder);
}

Expand Down
26 changes: 26 additions & 0 deletions src/Tests/Spectre.Console.Tests/Unit/StyleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,5 +405,31 @@ public void Should_Return_Expected_Markup_For_Style_With_Only_Background_Color()
// Then
result.ShouldBe("default on green");
}

[Fact]
public void Should_Return_Expected_Markup_For_Style_With_Only_Link()
{
// Given
var style = new Style(link:"https://spectreconsole.net/");

// When
var result = style.ToMarkup();

// Then
result.ShouldBe("link=https://spectreconsole.net/");
}

[Fact]
public void Should_Return_Expected_Markup_For_Style_With_Background_And_Link()
{
// Given
var style = new Style(background: Color.Blue, link: "https://spectreconsole.net/");

// When
var result = style.ToMarkup();

// Then
result.ShouldBe("default on blue link=https://spectreconsole.net/");
}
}
}