-
-
Notifications
You must be signed in to change notification settings - Fork 596
Add parsed unknown flag to remaining arguments for a branch with a default command #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
patriksvensson
merged 5 commits into
spectreconsole:main
from
FrankRay78:Add-parsed-unknown-flag-to-remaining-arguments-for-a-branch-(or-branch-of-a-branch)-with-a-default-command
Apr 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests had incorrect expectations for the parsing of branch + default command arguments
This was referenced Oct 9, 2024
Fully implemented and ready for reviewImportant: Please see the comment at the top of the issue description ahead of merging. |
patriksvensson
approved these changes
Apr 8, 2025
This was referenced Jul 22, 2025
This was referenced Sep 15, 2025
This was referenced Sep 22, 2025
This was referenced Sep 29, 2025
This was referenced Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of CLI bug fixes/enhancements intended to be released prior to Spectre.Console V1.0
They should be individually reviewed and merged (and then the open ones rebased) in the following order, given they have been successively branched from each other (Rationale: earlier changes, particularly to CommandExecutor, are relied upon later). Separate PRs should aid the reviewer.
fixes #1607
Changes
Please upvote 👍 this pull request if you are interested in it.