Skip to content

Don't erase secret prompt text upon backspace when mask is null #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Don't erase secret prompt text upon backspace when mask is null #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Spectre.Console/Extensions/AnsiConsoleExtensions.Input.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ internal static async Task<string> ReadLine(this IAnsiConsole console, Style? st
if (text.Length > 0)
{
text = text.Substring(0, text.Length - 1);
console.Write("\b \b");

if (mask != null)
{
console.Write("\b \b");
}
}

continue;
Expand Down
1 change: 1 addition & 0 deletions ....Console.Tests/Expectations/Prompts/Text/SecretValueBackspaceNullMask.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Favorite fruit?
19 changes: 19 additions & 0 deletions test/Spectre.Console.Tests/Unit/Prompts/TextPromptTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,25 @@ public Task Should_Choose_Masked_Default_Value_If_Nothing_Is_Entered_And_Prompt_
return Verifier.Verify(console.Output);
}

[Fact]
[Expectation("SecretValueBackspaceNullMask")]
public Task Should_Not_Erase_Prompt_Text_On_Backspace_If_Prompt_Is_Secret_And_Mask_Is_Null()
{
// Given
var console = new TestConsole();
console.Input.PushText("Bananas");
console.Input.PushKey(ConsoleKey.Backspace);
console.Input.PushKey(ConsoleKey.Enter);

// When
console.Prompt(
new TextPrompt<string>("Favorite fruit?")
.Secret(null));

// Then
return Verifier.Verify(console.Output);
}

[Fact]
[Expectation("SecretDefaultValueCustomMask")]
public Task Should_Choose_Custom_Masked_Default_Value_If_Nothing_Is_Entered_And_Prompt_Is_Secret_And_Mask_Is_Custom()
Expand Down