Improve handling of numeric SQL types and BigDecimal conversion #1247
+59
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for NUMERIC and DECIMAL SQL types in `BasicSQLUtils`, ensuring proper conversion from various data types. In `GenericDBConversion`, introduced a helper method to safely convert objects to BigDecimal and updated relevant code to use it, improving robustness and error handling. Also added logic to set nulls for specific field patterns during DB conversion. Co-Authored-By: Gitesh Sagvekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done by @Gitesh307!
These changes add support for NUMERIC and DECIMAL SQL types in
BasicSQLUtils, ensuring conversion works correctly when going from Specify 5 to 6.8.03. InGenericDBConversion, he introduced a helper method to safely convert objects to BigDecimal.