feat(core/dfn-index): add prefer-full-spec-title class and localize text #5073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcoscaceres
commented
Oct 10, 2025
marcoscaceres
commented
- Add prefer-full-spec-title CSS class to show full spec titles instead of keys
- Localize 'defines the following' text across all supported languages
- Add comprehensive tests for both features
- Local terms remain unaffected by prefer-full-spec-title class
- Add prefer-full-spec-title CSS class to show full spec titles instead of keys - Localize 'defines the following' text across all supported languages - Add comprehensive tests for both features - Local terms remain unaffected by prefer-full-spec-title class
✅ Deploy Preview for respec-pr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a prefer-full-spec-title CSS class to the definition index that displays full specification titles instead of abbreviated keys, and localizes the "defines the following" text across all supported languages.
- Adds localization for "defines the following" text in 8 languages
- Implements
prefer-full-spec-titleclass functionality to show full spec titles - Adds comprehensive tests for both new features
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/core/dfn-index.js | Adds localization strings, imports biblio module, and implements prefer-full-spec-title logic |
| tests/spec/core/dfn-index-spec.js | Adds tests for localization and prefer-full-spec-title functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
sidvishnoi
reviewed
Oct 10, 2025
sidvishnoi
approved these changes
Oct 10, 2025
Member
|
@marcoscaceres can you update wiki for https://github.com/speced/respec/wiki/index as well? |
Contributor
Author
|
Will do! |
Contributor
Author
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.