Add 'Annotation' class as a part of the SPDX 2.1 specification. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-nisar
force-pushed
the
annotation-spec-2.1
branch
2 times, most recently
from
ccca9a3 to
8cb3582
Compare
yash-nisar
changed the title
Member
|
This needs to be updated to resolve merge conflicts. |
yash-nisar
force-pushed
the
annotation-spec-2.1
branch
from
c049034 to
960367c
Compare
Add 'annotator','annotation_date', and 'comment' to the 'annotation' class. Signed-off-by: Yash Nisar <[email protected]>
Signed-off-by: Yash Nisar <[email protected]>
Signed-off-by: Yash Nisar <[email protected]>
yash-nisar
force-pushed
the
annotation-spec-2.1
branch
from
960367c to
413edaa
Compare
pombredanne
requested changes
Aug 10, 2018
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Looking good!... I made some veryminor comments for your consideration
| def test_correct_annotation_spdx_id(self): | ||
| spdx_id = 'SPDXRef-45' | ||
| self.add_annotator() | ||
| self.builder.set_annotation_spdx_id(self.document, spdx_id) |
Member
There was a problem hiding this comment.
What do you assert as test result here?
| self.write_tagvalue_file(doc, filename) | ||
| ############################################### | ||
| doc, error = self.parse_tagvalue_file(filename) | ||
| # print(doc.annotations[-1].annotation_type) |
Member
There was a problem hiding this comment.
you likely want to delete this
| for lics in doc.extracted_licenses: | ||
| print '\tIdentifier: {0}'.format(lics.identifier) | ||
| print '\tName: {0}'.format(lics.full_name) | ||
| print 'Annotations:' |
Member
There was a problem hiding this comment.
for the examples to also work on Python 3, please import the future print function and use it.
Member
|
Actually these are so inor that you can address these comments seprately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'annotator','annotation_date', and 'comment'
to the 'annotation' class.
Signed-off-by: Yash Nisar [email protected]