Report an error when UNKNOWN_TAG is found #55
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-nisar
force-pushed
the
unknown_tag_bug
branch
from
8959d35 to
b35f7d6
Compare
Contributor
Author
|
Review required @pombredanne @krysnuvadga :) |
yash-nisar
force-pushed
the
unknown_tag_bug
branch
from
b35f7d6 to
0f32bc7
Compare
yash-nisar
force-pushed
the
unknown_tag_bug
branch
from
0f32bc7 to
3700acc
Compare
krysnuvadga
approved these changes
Jun 1, 2018
Collaborator
krysnuvadga
left a comment
krysnuvadga
left a comment
There was a problem hiding this comment.
@pombredanne this PR is good to be merged! Maybe just one more review to confirm
Member
|
@yash-nisar can you update or rebase this branch? |
The cause of the error was the method `p_unknown_tag` in `parsers/tagvalue.py`. Due to the incorrect context-free grammar specification defined in the method, the line after the `unknown_tag` was not taken into consideration. The context-free grammar specification was rectified and tests were corresponding tests were added. Signed-off-by: Yash Nisar <[email protected]>
yash-nisar
force-pushed
the
unknown_tag_bug
branch
from
3700acc to
944125c
Compare
Contributor
Author
|
@pombredanne Updated the branch :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of the error was the method
p_unknown_tagin
parsers/tagvalue.py. Due to the incorrect context-free grammar specification defined in the method, the line after theunknown_tagwas not taken into consideration. Thecontext-free grammar specification was rectified and tests
were corresponding tests were added.
Signed-off-by: Yash Nisar [email protected]