Support multiple packages per SPDX document. #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 8, 2021 15:46
Signed-off-by: Jeff Licquia <[email protected]>
Signed-off-by: Jeff Licquia <[email protected]>
Signed-off-by: Jeff Licquia <[email protected]>
pombredanne
reviewed
Jun 10, 2021
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LTGM... I am not too worried about the CI hiccups... but let me see how the warning behaves in practice
Member
|
All good to me. Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches adds support for multiple packages per document, by adding document.packages as an array. The API for managing multiple packages is set up to mimic the other APIs for managing multiple objects (files, external licenses, etc.).
To preserve backwards compatibility, this patch introduces document.package as a property; this property is implemented using document.packages behind the scenes, and triggers a DeprecationWarning.
Support is included for parsing documents with multiple packages, as well as writing such documents.
Fixes #79.