update isSingleToken to return false for null and empty strings #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bact
approved these changes
Jun 17, 2025
Collaborator
bact
left a comment
bact
left a comment
There was a problem hiding this comment.
Also need to update the Javadoc string too.
From:
A single token string is a string that contains zero or one token,
To something along this line:
A single token string contains exactly one token, no more, no less,
Member
Author
|
Good catch @bact - I updated the javadocs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning true causes index out of bounds errors in other libraries.
Note: my previous analysis that it should return true was incorrect.