Skip to content

Add links to API doc of SPDX Java libraries #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goneall merged 4 commits into from
Apr 26, 2025
Merged

Add links to API doc of SPDX Java libraries #319

goneall merged 4 commits into from
Apr 26, 2025

Conversation

@bact
Copy link
Collaborator

@bact bact commented Apr 25, 2025 •
edited
Loading

@bact bact added the documentation Improvements or additions to documentation label Apr 25, 2025
@bact bact requested review from goneall and pmonks April 25, 2025 23:36
pmonks
pmonks reviewed Apr 26, 2025
View reviewed changes
Copy link
Collaborator

@pmonks pmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great! Just had a few nitpicks, mostly minor. Nice work @bact!

bact added 2 commits April 26, 2025 09:50
@bact
Update per review suggestions
ad6f02f 
- Add table heading
- Add description of libraries
- Move up the API doc table
- Revise lib version compatibility

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Update development status
7c85b18 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact mentioned this pull request Apr 26, 2025
Closed
@bact
Update README.md
8bb11e4 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@pmonks
Copy link
Collaborator

pmonks commented Apr 26, 2025

LGTM! 👍

goneall
goneall approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @bact

A few of the GitHub pages are not yet live, but I'll go ahead and merge this since it's a bit improvement over the current README

@goneall goneall merged commit 620d9f0 into spdx:master Apr 26, 2025
1 check passed
@bact bact deleted the add-javadoc-links branch April 26, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmonks pmonks pmonks approved these changes

@goneall goneall goneall approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Link to SPDX core and generated model classes JavaDocs from README Update "Development Status" in README to stable

3 participants

@bact @pmonks @goneall