Add support for using LicenseExpression in converter #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to the Spdx2to3Converter to use simple licensing license expressions instead of the ExpandedLicensing fully modelled license expressions Also includes a fix for #250 Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
goneall
force-pushed
the
simplelicense
branch
from
ef85a7e to
9f586a6
Compare
pmonks
approved these changes
Sep 24, 2024
Collaborator
pmonks
left a comment
pmonks
left a comment
There was a problem hiding this comment.
Another issue+fix that I don't feel I have a really solid grasp of (I've done very little with the SPDX model to date), but the code changes seems reasonably straight forward and the tests pass locally.
| } | ||
|
|
||
| /** | ||
| * Converts an SPDX spec version 2 SPDX AnyLicenseIfno to an SPDX spec version 3 LicenseExpression |
|
|
||
| /** | ||
| * Converts an SPDX spec version 2 SPDX AnyLicenseIfno to an SPDX spec version 3 LicenseExpression | ||
| * @param fromLicense an SPDX spec version 2 AnyLicenseIfno |
Member
Author
There was a problem hiding this comment.
Thanks for the catches @pmonks - I'll add a fix
Signed-off-by: Gary O'Neall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the Spdx2to3Converter to use simple licensing license expressions instead of the
ExpandedLicensing fully modelled license expressions
Also includes a fix for #250