Skip to content

resolve #34, unset glideImage object to save memory on regenerate or bulkinsert #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pamo85
Copy link

@pamo85 pamo85 commented Jul 30, 2015

No description provided.

@pamo85 pamo85 changed the title fix#34, unset glideImage object to save memory on regenerate or bulkinsert resolve #34, unset glideImage object to save memory on regenerate or bulkinsert Jul 30, 2015
@freekmurze
Copy link
Member

Have you tested this yourself? In my tests this change doesn't solve the problem. There's still a memory leak.

@pamo85
Copy link
Author

pamo85 commented Jul 30, 2015

yes i tested it. it solves memory leak from ram allocated by image object in glide. there's still a memory leak left somewhere. but regenerating 300 images only leaks about 10mb instead of 3gb memory.

@freekmurze
Copy link
Member

Mmm, on my machine the leak remained even after your fix. I

I've updated the underly Glide package to resolve the memory issue. Could you, in your project, run a composer update to get the latest version of the medialibrary and version 2.2.5 of spatie/laravel-glide (that one has been released a few minutes ago). Run your tests again and let me know if it is fixed.

@pamo85
Copy link
Author

pamo85 commented Jul 30, 2015

i tried it. calling the gc does the job. even better than my solution.

@freekmurze
Copy link
Member

Nice! Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants