Adding ".Sparkle" to appSupportPath #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
finish_installation.app and pkg files will not be removed when we use *.pkg installer and restart system in the installer.
In this case, "Application Support" directory is corrupted by unnecessary pkg files.
We need to scan files under "Application Support" directory and examine whether pkg file or not
in order to remove these pkg files.
It is quite annoying.
Solution
This patch changes location of finish_installation.app and pkg files to
"~/Library/Application Support/APPNAME/.Sparkle".
pkg file will be downloaded into
"~/Library/Application Support/APPNAME/.Sparkle/APPNAME VERSION/APPNAME.pkg".
Then, we can remove finish_installation.app and pkg files certainly by removing
"~/Library/Application Support/APPNAME/.Sparkle".