Small Clarifying Changes to Base Geodetic Configuration (AP/Wifi)

[tonycanike]

Subject of the issue

In a long-running commentary on #417, @amlago and I debated, discussed, and agreed on small changes that would significantly clarify and improve the AP/Wifi Geodetic Base configuration:

I'm opening a separate issue to document and request these requested small changes. #417 is already labelled as being in the RC and I didn't want the subsequent discussion and agreement in #417 to get missed.

Note this is not a resign/overhaul of this UI, that is a separate issue #330 which has been updated and closed.

Your workbench

3.2 RC

Requested Changes in #417 (comment)

But in general we can come to agree.

1. We replace the Adjust mark check with two radio buttons, one for Calculate HAE Mark and another for calculating HAE APC and only one can be selected.
2. If Calculate HAE Mark radio button is selected, the h is loaded in the HAE APC box
3. If Calculate HAE APC radio button is selected, h is loaded in the HAE Mark box
4. The "Paste LLh Coordinates" button is renamed "Load LLh from ZED" .
5. When the coordinates are loaded from the ZED (button "Load LLh from ZED"), the "Calculate HAE Mark" radio button is set, the ZED's HAE is loaded into the HAE APC box, and the HAE Mark is calculated.
6. When the coordinates come from the file, the "Calculate HAE APC" radio button is set, the file's HAE is loaded into the HAE Mark box, and the HAE APC is calculated.
7. There's a [Recalculate] button so people can correct their antenna height and phase center offset and recalculate.
8. if "Calc HAE Mark" is selected, the HAE Mark field is not editable. if "Calc HAE APC" is selected, the HAE APC field is not editable. Other fields are editable.
9. I like that the antenna heights and ARP are saved to the file, even if I change them later. That they continue to be saved would be my opinion.
10. If it were simple, the ARP could be filled in automatically, depending on whether Facet or Facet-L is used.

If this summary is programmed, I am very satisfied.

Greetings
Angel

[nseidle]

@amlago @tonycanike - You two are amazing. Thank you for collaborating, debating, and arriving at a good solution. Also, thank you for the clear work orders :)

We replace the Adjust mark check with two radio buttons, one for Calculate HAE Mark and another for calculating HAE APC and only one can be selected.

Done

If Calculate HAE Mark radio button is selected, the h is loaded in the HAE APC box. If Calculate HAE APC radio button is selected, h is loaded in the HAE Mark box

Loaded when? When the user clicks 'Load LLh from ZED'? Or Load from the commonly used table? I will assume both.

The "Paste LLh Coordinates" button is renamed "Load LLh from ZED" .

Done.

When the coordinates are loaded from the ZED (button "Load LLh from ZED"), the "Calculate HAE Mark" radio button is set, the ZED's HAE is loaded into the HAE APC box, and the HAE Mark is calculated. When the coordinates come from the file, the "Calculate HAE APC" radio button is set, the file's HAE is loaded into the HAE Mark box, and the HAE APC is calculated.

Done.

There's a [Recalculate] button so people can correct their antenna height and phase center offset and recalculate.

Is this needed? The disabled field (HAE APC or HAE Mark, depending on radio button state) is recalculated with every change.

if "Calc HAE Mark" is selected, the HAE Mark field is not editable. if "Calc HAE APC" is selected, the HAE APC field is not editable. Other fields are editable.

Done.

I like that the antenna heights and ARP are saved to the file, even if I change them later. That they continue to be saved would be my opinion.

Done.

If it were simple, the ARP could be filled in automatically, depending on whether Facet or Facet-L is used.

Done.

This will be in the RC shortly. Please let me know what else needs to change.

[amlago]

Hi @nseidle
Thank you for your very positive comments. It encourages further discussion on firmware improvements.
Always on command.

Regarding the changes to the base configuration, as soon as I can test them I will inform you.

Greetings
Angel

[tonycanike]

Excellent! That was fast work @nseidle!

I concur with your clarifications/decisions and I don't believe the recalculate button is necessary.

[amlago]

I just tried the new firmware.
I think that point 5) and 6) still do not automatically activate the corresponding button radio.

"5-When the coordinates are loaded from the ZED (button "Load LLh from ZED"), the "Calculate HAE Mark" radio button is set, the ZED's HAE is loaded into the HAE APC box, and the HAE Mark is calculated."

"6-When the coordinates come from the file, the "Calculate HAE APC" radio button is set, the file's HAE is loaded into the HAE Mark box, and the HAE APC is calculated."

[amlago]

Clarifications on points 5 and 6.
We don't want two possible button radio options for the Load LLh from ZED button and also for the Load button when using file coordinates. The button radios to be marked are opposite and unique.

*.If we use the Load LLh from Zed button, the Calculate HAE Mark-(Point 5) radio button should be checked automatically

*.If we use the Load button for file coordinates, the Calculate HAE APC radio button should be checked automatically (Point 6)

Greetings

[amlago]

I think if we have two radio button options when loading coordinates, it may be misleading for less experienced people.
At the beginning I liked the idea of having the two radio buttons enabled for the option to load coordinates with the Load from file button, but in conversations with Tony I came to the conclusion that confusion could be generated.

[nseidle]

5-When the coordinates are loaded from the ZED (button "Load LLh from ZED"), the "Calculate HAE Mark" radio button is set, the ZED's HAE is loaded into the HAE APC box, and the HAE Mark is calculated.

6-When the coordinates come from the file, the "Calculate HAE APC" radio button is set, the file's HAE is loaded into the HAE Mark box, and the HAE APC is calculated.

Ok, I think I've got this functionality working. Please check my work.

[amlago]

@nseidle
Nathan.
It worked. Excellent.

@tonycanike
Tony. Try it when you can. It will make my work in the field much easier.

Greetings

[tonycanike]

I look forward to trying all this amazing work out! Thank you! I'm heading into the field next week and will try it then.

[XPav]

I'm looking at the changes in 3.2, and I'm a little unclear exactly which heights we're talking about. Is there a diagram or ascii art or something that I can refer too to make sure I'm going the right directions and putting in the right numbers?