Feature@/3.24 dark mode #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dark mode move code base to 3.24
set initial state to 'true' instead of 'false', which fixes a lot of network-related errors.
thomaskim1130
requested changes
Nov 14, 2024
There was a problem hiding this comment.
정말 수고하셨습니다! dialog 바로 반영해 주신 점 감사합니다.
다만 페이지를 리프레쉬할 때 발생하는 'RefreshIndicator.adaptive'(현재 제가 개편 중)에서 color, backgroundColor option을 변경할 수 있는데, 여기에도 다크테마를 반영해 주시면 좋을 것 같습니다.
https://api.flutter.dev/flutter/material/RefreshIndicator/RefreshIndicator.adaptive.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Dark Mode 완료 하였습니다.
아직 다크 모드 설정을 캐시로 불러오는 기능은 없습니다.
Changes
Implementaion Method
After Changes
Related Issues
Rollback Scenario
TODO