Skip to content

Conversation

@asamaayako
Copy link
Contributor

…_type function

Description

"This PR refactors the PyResponse::new method to delegate the body type checking to a dedicated function called check_body_type. The modification ensures that type validation logic is encapsulated within a single, reusable function, improving the code's readability and maintainability."

@vercel
Copy link

vercel bot commented Jul 11, 2024

@asamaayako is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

@asamaayako asamaayako marked this pull request as ready for review July 11, 2024 01:51
@asamaayako asamaayako changed the title Refactor: PyResponse::new to delegate body type checking to check_body… refactor: PyResponse::new to delegate body type checking to check_body… Jul 11, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 11, 2024

CodSpeed Performance Report

Merging #891 will not alter performance

Comparing asamaayako:refactor/check-body-type-should-call-function (17c9154) with main (fc1bcd5)

Summary

✅ 110 untouched benchmarks

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM! 👍

@vercel
Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 0:50am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants