-
-
Notifications
You must be signed in to change notification settings - Fork 312
chore: fix pyproject and poetry run test_server command #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@AntoineRR is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #746 will not alter performanceComparing Summary
|
sansyrox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AntoineRR 👋
Welcome back 😄 How's everything been?
Thank you for the PR! I have some suggestions. Do let me know what you think :D
docs_src/src/pages/documentation/api_reference/getting_started.mdx
Outdated
Show resolved
Hide resolved
sansyrox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work as always @AntoineRR 🔥
Description
Hi, I came back to the project after some time and found a few things that didn't work, here is a fix for :
poetry run test_servercommand, which failed because thedi_subrouterimport path was absolute and not relativepyproject.tomlfile, this should make the links appear in pypitool.poetryin thepyproject.tomlfile, to match the one underprojectCheers 😄
Edit :
I added a few more fixes :
set_tokenmethod ofBearerGetterwasn't working because the__setitem__method wasn't implemented forHeaders