Skip to content

Conversation

@AntoineRR
Copy link
Collaborator

@AntoineRR AntoineRR commented Feb 4, 2024

Description

Hi, I came back to the project after some time and found a few things that didn't work, here is a fix for :

  • the poetry run test_server command, which failed because the di_subrouter import path was absolute and not relative
  • links in the pyproject.toml file, this should make the links appear in pypi
  • the version of the project under tool.poetry in the pyproject.toml file, to match the one under project

Cheers 😄

Edit :

I added a few more fixes :

  • the set_token method of BearerGetter wasn't working because the __setitem__ method wasn't implemented for Headers
  • some typing related issues that Pylance noticed

@vercel
Copy link

vercel bot commented Feb 4, 2024

@AntoineRR is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 4, 2024

CodSpeed Performance Report

Merging #746 will not alter performance

Comparing AntoineRR:various-fixes (63d37d1) with main (a097fc7)

Summary

✅ 106 untouched benchmarks

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AntoineRR 👋

Welcome back 😄 How's everything been?

Thank you for the PR! I have some suggestions. Do let me know what you think :D

@AntoineRR AntoineRR requested a review from sansyrox February 4, 2024 20:28
@AntoineRR AntoineRR requested a review from sansyrox February 5, 2024 19:53
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work as always @AntoineRR 🔥

@sansyrox sansyrox merged commit 13e9f13 into sparckles:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants