Skip to content

Conversation

@IdoKendo
Copy link
Contributor

@IdoKendo IdoKendo commented Oct 6, 2023

Description

This PR fixes #574 by exposing Url and Request's new methods from rust to the python API, thus allowing developers to create them in tests in order to build unit tests that don't require starting a server.

@netlify
Copy link

netlify bot commented Oct 6, 2023

👷 Deploy request for robyn pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit df24a40

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:45pm

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 6, 2023

CodSpeed Performance Report

Merging #630 will not alter performance

Comparing IdoKendo:feat/add-constructors-for-testing (df24a40) with main (82e12a7)

Summary

✅ 106 untouched benchmarks

@sansyrox
Copy link
Member

sansyrox commented Oct 6, 2023

I love how we are improving testability. GG @IdoKendo 🔥

@IdoKendo
Copy link
Contributor Author

IdoKendo commented Oct 6, 2023

I love how we are improving testability. GG @IdoKendo 🔥

Yeah, it's really important IMO! By the way, I'm noticing the macOS integration tests are a bit flaky... Any idea what could be the cause?

@sansyrox
Copy link
Member

sansyrox commented Oct 6, 2023

@IdoKendo , a good solution would be not to depend on network calls this much and to have a proper testing client 😅

But one reason could be that we are spawning and killing multiple processes very frequently.

@IdoKendo
Copy link
Contributor Author

IdoKendo commented Oct 6, 2023

@IdoKendo , a good solution would be not to depend on network calls this much and to have a proper testing client 😅

But one reason could be that we are spawning and killing multiple processes very frequently.

Yeah, I guess once the testing client PR will be merged we can create a more resilient testing suite.

@IdoKendo IdoKendo requested a review from sansyrox October 7, 2023 15:57
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@sansyrox sansyrox merged commit f9eb7ff into sparckles:main Oct 7, 2023
@IdoKendo IdoKendo deleted the feat/add-constructors-for-testing branch October 10, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How can i import the Url from robyn?

2 participants