-
-
Notifications
You must be signed in to change notification settings - Fork 313
feat: add Request and Url objects constructors to enable easier testing #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Request and Url objects constructors to enable easier testing #630
Conversation
👷 Deploy request for robyn pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #630 will not alter performanceComparing Summary
|
|
I love how we are improving testability. GG @IdoKendo 🔥 |
Yeah, it's really important IMO! By the way, I'm noticing the macOS integration tests are a bit flaky... Any idea what could be the cause? |
|
@IdoKendo , a good solution would be not to depend on network calls this much and to have a proper testing client 😅 But one reason could be that we are spawning and killing multiple processes very frequently. |
Yeah, I guess once the testing client PR will be merged we can create a more resilient testing suite. |
sansyrox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Description
This PR fixes #574 by exposing Url and Request's
newmethods from rust to the python API, thus allowing developers to create them in tests in order to build unit tests that don't require starting a server.