feat: add server sent events #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
this is a very early implementation with a lot of bugs. need to create a better version when I am not delirious. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
|
😱 Found 2 issues. Time to roll up your sleeves! 😱 Need help? Join our Discord for support! |
CodSpeed Performance ReportMerging #1200 will not alter performanceComparing Summary
Benchmarks breakdown
|
sansyrox
commented
Jul 3, 2025
integration_tests/conftest.py
Outdated
Comment on lines
46
to
56
|
|
||
| # Ensure environment variables are properly set for the subprocess | ||
| env = os.environ.copy() | ||
| env["ROBYN_HOST"] = domain | ||
| env["ROBYN_PORT"] = str(port) | ||
|
|
||
| if platform.system() == "Windows": | ||
| command[0] = "python" | ||
| process = subprocess.Popen(command, shell=True, creationflags=subprocess.CREATE_NEW_PROCESS_GROUP, env=env) | ||
| else: | ||
| process = subprocess.Popen(command, preexec_fn=os.setsid, env=env) |
Member
Author
There was a problem hiding this comment.
do we need this? Prolly not
Member
Author
|
@Recurse-ML re-review |
Member
Author
|
Quite satisfied with the implementation now. Will write docs. |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1199
Summary
This PR implements server sent events
PR Checklist
Please ensure that:
Pre-Commit Instructions: