Fix some minor things I noticed while doing the mypy PR

[WilliamJamieson]

This PR fixes a couple of things that I noticed while doing the mypy PR #566. These didn't fit with that theme nor do they fit anywhere else.

Tasks

• Update or add relevant roman_datamodels tests.
• Update relevant docstrings and / or docs/ page.
• Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
  • Write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types).
  • Start a romancal regression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").

News fragment change types:

• changes/<PR#>.feature.rst: new feature
• changes/<PR#>.bugfix.rst: fixes an issue
• changes/<PR#>.doc.rst: documentation change
• changes/<PR#>.removal.rst: deprecation or removal of public API
• changes/<PR#>.misc.rst: infrastructure or miscellaneous change

[codecov]

Codecov Report

❌ Patch coverage is 90.65421% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.53%. Comparing base (087a60d) to head (46ad2c6).
⚠️ Report is 197 commits behind head on main.

Files with missing lines	Patch %	Lines
src/roman_datamodels/stnode/_tagged.py	88.57%	4 Missing ⚠️
src/roman_datamodels/datamodels/_core.py	77.77%	2 Missing ⚠️
src/roman_datamodels/stnode/_mixins.py	86.66%	2 Missing ⚠️
src/roman_datamodels/datamodels/_utils.py	75.00%	1 Missing ⚠️
src/roman_datamodels/stnode/_node.py	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   97.56%   95.53%   -2.03%     
==========================================
  Files          30       41      +11     
  Lines        2788     4279    +1491     
==========================================
+ Hits         2720     4088    +1368     
- Misses         68      191     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[braingram]

Overall LGTM but docs are failing would you take a look at what's causing the failure? Also would you run the regtests with this branch when it's updated to fix the docs?

[braingram]

Thanks. The comment in e31f20c looks great. Would you run the regtests with this PR?

[WilliamJamieson]

Everything passes https://github.com/spacetelescope/RegressionTests/actions/runs/17922075901/job/50959427064

[WilliamJamieson]

@braingram commit 1a47c73 of this PR is simply what I linked to in #569 (comment). I am happy for you to us this for #569, or some other similar change or we can simply include it as part of this PR. It just made sense to rebase these changes on those as otherwise the merge conflicts will get annoying to deal with.

[braingram]

@braingram commit 1a47c73 of this PR is simply what I linked to in #569 (comment). I am happy for you to us this for #569, or some other similar change or we can simply include it as part of this PR. It just made sense to rebase these changes on those as otherwise the merge conflicts will get annoying to deal with.

Thanks. I haven't had time to address the requested changes in #569. I have no objection if you updated this PR with a changelog describing the changes in 1a47c73 and I'll close #569.

[WilliamJamieson]

@braingram commit 1a47c73 of this PR is simply what I linked to in #569 (comment). I am happy for you to us this for #569, or some other similar change or we can simply include it as part of this PR. It just made sense to rebase these changes on those as otherwise the merge conflicts will get annoying to deal with.

Thanks. I haven't had time to address the requested changes in #569. I have no objection if you updated this PR with a changelog describing the changes in 1a47c73 and I'll close #569.

Done.

Resolved

[braingram]

Just one question about the empty __init__.

[braingram]

LGTM. I'll retrigger the regtests than merge once those pass.