Skip to content

Conversation

@braingram
Copy link
Collaborator

@braingram braingram commented Sep 12, 2025

Requires spacetelescope/romancal#1954

Removes the unused AssociationsModel.

See spacetelescope/romancal#1846 for more details.

Regtests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/17917081333

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.57%. Comparing base (087a60d) to head (291ecb1).
⚠️ Report is 189 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   97.56%   95.57%   -1.99%     
==========================================
  Files          30       41      +11     
  Lines        2788     4160    +1372     
==========================================
+ Hits         2720     3976    +1256     
- Misses         68      184     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamJamieson
Copy link
Collaborator

WilliamJamieson commented Sep 18, 2025

Do you think we need this

def test_open_asn(tmp_path):
romancal = pytest.importorskip("romancal")
fn = tmp_path / "test.json"
asn = {
"products": [
{
"members": [],
"name": "foo",
}
],
}
with open(fn, "w") as f:
json.dump(asn, f)
lib = datamodels.open(fn)
assert isinstance(lib, romancal.datamodels.ModelLibrary)
test anymore? If not we may want to remove it and all the "with romancal" related CI jobs

Never mind I thought that was using this model to open the ASN.

@braingram braingram force-pushed the rm_associations_model branch from 39a3ff4 to 291ecb1 Compare September 22, 2025 13:34
@braingram braingram marked this pull request as ready for review September 22, 2025 13:55
@braingram braingram requested a review from a team as a code owner September 22, 2025 13:55
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 3dbb92f into spacetelescope:main Sep 22, 2025
20 of 21 checks passed
@braingram braingram deleted the rm_associations_model branch September 22, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants