-
Notifications
You must be signed in to change notification settings - Fork 25
remove AssociationsModel #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove AssociationsModel #562
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 97.56% 95.57% -1.99%
==========================================
Files 30 41 +11
Lines 2788 4160 +1372
==========================================
+ Hits 2720 3976 +1256
- Misses 68 184 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
roman_datamodels/tests/test_open.py Lines 240 to 257 in 867de77
Never mind I thought that was using this model to open the ASN. |
39a3ff4 to
291ecb1
Compare
PaulHuwe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requires spacetelescope/romancal#1954
Removes the unused
AssociationsModel.See spacetelescope/romancal#1846 for more details.
Regtests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/17917081333
Tasks
roman_datamodelstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change