fix: pin chrono to avoid build errors with arrow #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
approved these changes
Feb 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 295 295
Lines 49348 49348
=======================================
Hits 47075 47075
Misses 2273 2273 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 0.74.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
JayWhite2357
pushed a commit
that referenced
this pull request
Mar 7, 2025
Updates the requirements on [opentelemetry](https://github.com/open-telemetry/opentelemetry-rust) to permit the latest version. - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry-0.22.0...opentelemetry-0.22.0) --- updated-dependencies: - dependency-name: opentelemetry dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ian Alexander Joiner <[email protected]>
JayWhite2357
pushed a commit
that referenced
this pull request
Mar 7, 2025
# Rationale for this change chrono `v0.4.40` implemented a `quarter` method that causes build errors when building with arrow. See bug apache/arrow-rs#7196 and this commit apache/arrow-rs#7210. The suggested workaround is to pin chrono to `v0.4.39`. # What changes are included in this PR? - Pins chrono to the latest version that works with arrow, `v0.4.39` # Are these changes tested? Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
chrono
v0.4.40implemented aquartermethod that causes build errors when building with arrow. See bug apache/arrow-rs#7196 and this commit apache/arrow-rs#7210. The suggested workaround is to pin chrono tov0.4.39.What changes are included in this PR?
v0.4.39Are these changes tested?
Yes