MRG: Consolidate reused code across gbsketch/urlsketch
#233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluegenes
force-pushed
the
streaming-urlsketch
branch
from
fa2ee2c to
669745e
Compare
bluegenes
force-pushed
the
streamline-functions
branch
from
0df14e9 to
20d9a85
Compare
bluegenes
force-pushed
the
streamline-functions
branch
from
20d9a85 to
1e747dd
Compare
Collaborator
Author
|
@ctb ready for review. This just consolidates reused setup code. Last one, I think/hope :) |
ctb
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're using the same processing functions (again), refactor and clean up all the rest of the code reused between
gbsketchandurlsketch