Skip to content

Conversation

@josh1248
Copy link
Contributor

Resolves #2814

Description

Resolves the issue of export CSV being unable to export all entries due to backend pagination. The solution is to connect to a backend endpoint outside of the Redux loop so that data can be exported independently of what is shown to the user. (This will be an admin-only button to avoid excess server fees)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Start up both the updated backend and updated frontend.

  • Enter the 'Grading' tab.
  • Click the 'Export CSV' button at the grading table.
  • If you are logged in as an admin, you will receive a notification to download the CSV file.
  • If you are logged in as a staff, you will receive a 401 error.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11869868280

Details

  • 2 of 17 (11.76%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 31.309%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/grading/Grading.tsx 0 4 0.0%
src/commons/sagas/RequestsSaga.ts 2 13 15.38%
Totals Coverage Status
Change from base Build 11568075789: -0.01%
Covered Lines: 4835
Relevant Lines: 14568

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits :)

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit fc4cb12 into source-academy:master Nov 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export CSV function regression after transfer of pagination of grading submissions from frontend to backend

3 participants