Skip to content

Conversation

@Dirreke
Copy link
Contributor

@Dirreke Dirreke commented Aug 5, 2024

@Dirreke Dirreke changed the title Bump ndarray from 0.15.6 to 0.6 Bump ndarray from 0.15.6 to 0.16 Aug 5, 2024
@Dirreke Dirreke changed the title Bump ndarray from 0.15.6 to 0.16 Bump ndarray from 0.15.3 to 0.16 Aug 5, 2024
@Dirreke
Copy link
Contributor Author

Dirreke commented Aug 5, 2024

Should I rename it to into_shape_with_order, which is the same as ndarray(rust-ndarray/ndarray#1310)

pub fn into_shape(mut self, shape: &[usize]) -> TractResult<Tensor> {

@kali
Copy link
Collaborator

kali commented Aug 5, 2024

Should I rename it to into_shape_with_order, which is the same as ndarray(rust-ndarray/ndarray#1310)

pub fn into_shape(mut self, shape: &[usize]) -> TractResult<Tensor> {

No reason to. Tensors in tract are always in "natural order" (row major, but generalized, axes with bigger strides come first).

@Dirreke
Copy link
Contributor Author

Dirreke commented Aug 14, 2024

Hi~ Shall we rerun CI?

@kali
Copy link
Collaborator

kali commented Aug 14, 2024

Hi~ Shall we rerun CI?

Sure, let's see where we are. :) But we need to address the ndarray-npy situation before moving further (as in merge).

@barakugav
Copy link

barakugav commented Sep 15, 2024

@Dirreke @kali ndarray-npy 0.9.1 was released, using ndarray 0.16, can we push this PR forward? looking forward to it

@Dirreke
Copy link
Contributor Author

Dirreke commented Sep 15, 2024

@kali Let's rerun CI. Thanks

@kali
Copy link
Collaborator

kali commented Sep 16, 2024

thanks for your contibution!

@kali kali merged commit 3997d20 into sonos:main Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants