Skip to content

Conversation

@shahiljain
Copy link

A generic cloud folder icon for apps like Nextcloud, GDrive, etc.

@yioannides
Copy link
Contributor

It would be better to use cloud-filled instead, for scalability / legibility:

image

A few more things:

  1. please make sure the proportions and alignment are correct
  2. don't forget to also include a legacy folder icon, as well as symbolic folder icon and an (aliased) symbolic legacy folder icon

If you're not sure how to go about it, you can refer to an existing PR like this one here for a places icon.

@Eggmanplant
Copy link

It would be better to use cloud-filled instead, for scalability / legibility:
image

A few more things:

1. please make sure the proportions and alignment are correct

2. don't forget to also include a legacy folder icon, as well as symbolic folder icon and an (aliased) symbolic legacy folder icon

If you're not sure how to go about it, you can refer to an existing PR like this one here for a places icon.

I'd say no since stock gnome folder icons aren't filled.

@yioannides
Copy link
Contributor

I'd say no since stock gnome folder icons aren't filled.

Either one is technically correct by HIG standards, but since GNOME provides both filled and outlined icons, it would be better to differentiate between folder icons and symbolic icons and also, the scalability of these two icons is vastly different:

image image

@shahiljain
Copy link
Author

Okay I can add a legacy and symbolic Icon as well, and as far as the cloud icon goes I think the outline looks better with the other gnome folder icons. I just need to figure out how to edit PRs.

@rivenirvana
Copy link

You can just keep committing new changes from your branch and pushing it again (force push if you're changing what you already pushed to your remote), the PR will update on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants