Skip to content

Conversation

demirgazetic
Copy link
Collaborator

@demirgazetic demirgazetic commented Aug 26, 2025

Description:

Closes #1809

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

Copy link

changeset-bot bot commented Aug 26, 2025

🦋 Changeset detected

Latest commit: dc91310

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 26, 2025

🚀 Storybook has been deployed for branch chore_status-icon-update

@demirgazetic demirgazetic marked this pull request as draft August 26, 2025 13:38
@demirgazetic demirgazetic changed the title chore: update status-check icon and Node.js engine to ^22.14.0 chore: update status-check icon Aug 28, 2025
@coraliefeil
Copy link
Contributor

Pls utilize "status-check" - Figma Link

@MartaPintoTeixeira MartaPintoTeixeira removed their assignment Sep 10, 2025
smfonseca
smfonseca previously approved these changes Sep 15, 2025
@smfonseca smfonseca removed their assignment Sep 15, 2025
Copy link
Contributor

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See cromatic comments please

Copy link
Contributor

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. There is only one little bug found in invalid. If it is fast to solve it please do.

@paulovareiro29 paulovareiro29 merged commit ae722bc into main Sep 16, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Solid Design System Project Board Sep 16, 2025
@paulovareiro29 paulovareiro29 deleted the chore/status-icon-update branch September 16, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat: ✨ replace valid icon on sd-input, sd-textarea, sd-combobox and sd-select
7 participants