program: Mark test module pub(crate)
#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The downstream agave jobs are failing after the upgrade to Rust 1.84, because the lint for public modules needing documentation is getting tripped. #### Summary of changes Mark the test module as `pub(crate)` since it shouldn't be used outside.
joncinque
added a commit
to joncinque/agave
that referenced
this pull request
Jan 16, 2025
#### Problem The downstream SPL jobs were disabled due to a new error caught by Rust 1.84. All of the program repos have been updated to mark their public test modules as `pub(crate)`: * record: solana-program/record#18 * libraries: solana-program/libraries#22 * token-2022: solana-program/token-2022#80 #### Summary of changes Re-enable the tests!
joncinque
added a commit
to joncinque/agave
that referenced
this pull request
Jan 16, 2025
#### Problem The downstream SPL jobs were disabled due to a new error caught by Rust 1.84. All of the program repos have been updated to mark their public test modules as `pub(crate)`: * record: solana-program/record#18 * libraries: solana-program/libraries#22 * token-2022: solana-program/token-2022#80 #### Summary of changes Re-enable the tests! Also, run the downstream jobs when rust-toolchain.toml is modified.
mergify bot
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Jan 16, 2025
#### Problem The downstream SPL jobs were disabled due to a new error caught by Rust 1.84. All of the program repos have been updated to mark their public test modules as `pub(crate)`: * record: solana-program/record#18 * libraries: solana-program/libraries#22 * token-2022: solana-program/token-2022#80 #### Summary of changes Re-enable the tests! Also, run the downstream jobs when rust-toolchain.toml is modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The downstream agave jobs are failing after the upgrade to Rust 1.84, because the lint for public modules needing documentation is getting tripped.
Summary of changes
Mark the test module as
pub(crate)since it shouldn't be used outside.