Adds a base dockerfile for the project #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soimort All three of the improvements have been implemented. [x] Update the readme
This is all set to merge now :) |
|
Nice job. Thanks! 👍 |
|
You're welcome - thanks for the handy tool!
…________________________________
From: Mort Yao <[email protected]>
Sent: Friday, March 20, 2020 9:04:26 PM
To: soimort/translate-shell <[email protected]>
Cc: Abhinav Sharma <[email protected]>; Author <[email protected]>
Subject: Re: [soimort/translate-shell] Adds a base dockerfile for the project (#336)
Merged #336<#336> into develop.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#336 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADBU2XVRJPWT5N3IMOZ5W33RIOEIFANCNFSM4KVZJSMA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @soimort,
I really like using the tool, thanks for building it!
I felt that perhaps, it might be easier for people to try this out or have a cross-platform reproducible environment for using
translate-shell.For now, I'm creating a draft PR with the basic dockerfile and would be happy to accomodate the changes which you might feel are necessary.
Here's what I have in mind for further work on this
[ ] Update the readme
[ ] Maybe try to get this working on a smaller
alpineimage[ ] Test with the RTL languages