Skip to content

Represent a package in Proc Macro Server more reliably #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Represent a package in Proc Macro Server more reliably #2042

merged 1 commit into from
Mar 10, 2025

Conversation

@integraledelebesgue
Copy link
Member

@integraledelebesgue integraledelebesgue commented Mar 4, 2025 •
edited
Loading

Changes

  • Proc Macro Server now identifies workspace packages using a CompilationUnitComponent type which wraps the name and discriminator of the Cairo package
  • This new API abstracts the implementation details about the package ids and names and reduces the reliance on implicit contracts

@integraledelebesgue integraledelebesgue requested review from a team and Draggu as code owners March 4, 2025 22:35
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch 2 times, most recently from 070bf3d to 2955b2b Compare March 4, 2025 22:49
@integraledelebesgue integraledelebesgue changed the title Use a newtype for the serialized PackageId in Proc Macro Server [Merge After 2.11] Use a newtype for the serialized PackageId in Proc Macro Server Mar 4, 2025
@integraledelebesgue integraledelebesgue mentioned this pull request Mar 4, 2025
Merged
Draggu
Draggu reviewed Mar 4, 2025
View reviewed changes
Draggu
Draggu reviewed Mar 5, 2025
View reviewed changes
piotmag769
piotmag769 reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with breaking the interface for more soundness tbh

@integraledelebesgue integraledelebesgue changed the title [Merge After 2.11] Use a newtype for the serialized PackageId in Proc Macro Server Use a newtype for the serialized PackageId in Proc Macro Server Mar 6, 2025
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch 2 times, most recently from 3cc25ce to 2946b39 Compare March 6, 2025 12:09
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch from 2946b39 to b72e7a8 Compare March 6, 2025 12:34
piotmag769
piotmag769 requested changes Mar 6, 2025
View reviewed changes
piotmag769
piotmag769 reviewed Mar 6, 2025
View reviewed changes
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch 2 times, most recently from 6dbfd8c to 31ffcfa Compare March 6, 2025 14:27
@integraledelebesgue integraledelebesgue changed the title Use a newtype for the serialized PackageId in Proc Macro Server Represent a package in Proc Macro Server more reliably Mar 6, 2025
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch from 31ffcfa to d4305f6 Compare March 6, 2025 14:45
piotmag769
piotmag769 approved these changes Mar 6, 2025
View reviewed changes
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch 3 times, most recently from 9f96409 to d5ad777 Compare March 6, 2025 15:43
piotmag769
piotmag769 reviewed Mar 6, 2025
View reviewed changes
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch 3 times, most recently from eedb882 to 63f8de6 Compare March 7, 2025 14:10
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch from 63f8de6 to 21027ed Compare March 7, 2025 15:50
piotmag769
piotmag769 reviewed Mar 7, 2025
View reviewed changes
@integraledelebesgue integraledelebesgue mentioned this pull request Mar 10, 2025
Closed
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch from 21027ed to f05561b Compare March 10, 2025 12:17
@integraledelebesgue integraledelebesgue force-pushed the feature/pms-type-model-improvement branch from f05561b to 00c0f57 Compare March 10, 2025 12:18
@integraledelebesgue integraledelebesgue added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 8caf288 Mar 10, 2025
17 of 19 checks passed
@integraledelebesgue integraledelebesgue deleted the feature/pms-type-model-improvement branch March 10, 2025 13:33
@integraledelebesgue integraledelebesgue restored the feature/pms-type-model-improvement branch March 10, 2025 14:16
@BrewTestBot BrewTestBot mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piotmag769 piotmag769 piotmag769 approved these changes

@maciektr maciektr maciektr approved these changes

@Draggu Draggu Draggu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@integraledelebesgue @maciektr @piotmag769 @Draggu