Skip to content

fix: add proper stack types #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix: add proper stack types #695

merged 1 commit into from
Nov 10, 2020

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Nov 9, 2020 •
edited
Loading

Description

Added change of types for stack actions in native-stack. Fixes #623.

Changes

Removed the explicit typings of stack router options and switched to StackActionHelpers which has all of them and replace action too.

Checklist

  • Updated TS types
  • Ensured that CI passes

@WoLewicki WoLewicki mentioned this pull request Nov 9, 2020
Closed
@WoLewicki WoLewicki merged commit 1b683b7 into master Nov 10, 2020
@WoLewicki WoLewicki deleted the @wolewicki/fix-replace-typing branch November 10, 2020 16:45
@WoLewicki WoLewicki mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@satya164 satya164 satya164 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Add 'replace' to stack navigator actions
2 participants
@WoLewicki @satya164