General Housekeeping #584
Merged
General Housekeeping #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
reviewed
Aug 3, 2020
|
Could you also rebase to the newest master? I see there is a conflict with one file. |
nonewcode
commented
Aug 3, 2020
WoLewicki
requested changes
Aug 4, 2020
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]> # Conflicts: # src/native-stack/views/NativeStackView.tsx
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]> # Conflicts: # src/createNativeStackNavigator.js
…mpty object Signed-off-by: Josh Kelly <[email protected]>
Signed-off-by: Josh Kelly <[email protected]>
… provides the same check Signed-off-by: Josh Kelly <[email protected]>
|
@WoLewicki Those conflicts should be sorted now, had to add this as a second remote and rebase from there instead of the fork (even though they had the same commit history, weird). |
WoLewicki
approved these changes
Aug 5, 2020
|
Thanks @WoLewicki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates various dev dependencies as well as making some small changes to a couple of the various checks inside props and an update to one of the types to not use
{}.The eslint configuration has also had a bit of an update and i fixed the new errors that arose from that change.