Skip to content

Conversation

kmichalikk
Copy link
Collaborator

Description

From discussion in #2987 (comment). We should rename the class into something more specific because it really does one specific thing.

Changes

title

Test code and steps to reproduce

No changes, disabling back button menu should still work. You can modify BottomTabsTest / Tab4 with screenOption={{ headerBackButtonMenuEnabled: false }}

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should rather be RNSBackBarButtonItem to keep the naming convention consistent, right?

@kmichalikk kmichalikk changed the title chore(iOS): Rename RNSUIBarButtonItem to RNSBarBackButtonItem chore(iOS): Rename RNSUIBarButtonItem to RNSBackBarButtonItem Aug 11, 2025
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Thank you! ✅

@kmichalikk kmichalikk merged commit 372b357 into main Aug 12, 2025
6 checks passed
@kmichalikk kmichalikk deleted the @kmichalikk/rns-ui-bar-button-rename branch August 12, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants