fix(iOS, SplitView): Break the retain cycle between component and controller for SplitViewScreen #3083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes:
https://github.com/software-mansion/react-native-screens-labs/issues/156
Problem:
.view
property.Solution:
SplitViewHost keeps references to all subviews of type SplitViewScreen all the time (columns might be hidden, but they won't disappear). It means that we can consider Host as an owner of the SplitViewScreens' lifecycles. If the host is about to be unmounted from the view hierarchy, we can perform some additional cleanup in child components to detach the reference to theirs controllers.
Changes
Test code and steps to reproduce
Create an example that includes a SplitView, which may be removed from the hierarchy, add log and observe.
Checklist