Skip to content

fix(iOS, Tabs): fix condition for applying text attributes in Appearance Coordinator #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

kligarski
Copy link
Contributor

Description

Fixes https://github.com/software-mansion/react-native-screens-labs/issues/323.

Before this fix, you couldn't modify font if you did not change size as well.

Changes

  • separate color and other font attributes to different if statements
  • check all relevant font props in condition
  • change nullability of text attributes
  • change check (count > 0 instead of nil-check)

Test code and steps to reproduce

Run TestBottomTabs, change font props other than font size. Props should apply to the text.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

Base automatically changed from @kligarski/fix-typo-in-appearance-coordinator to main July 29, 2025 13:00
@kligarski kligarski force-pushed the @kligarski/bottom-tabs-fix-title-props-logic branch from c194fd5 to cde074a Compare July 29, 2025 13:01
@kligarski kligarski merged commit f0d20c0 into main Jul 29, 2025
3 of 4 checks passed
@kligarski kligarski deleted the @kligarski/bottom-tabs-fix-title-props-logic branch July 29, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants