-
-
Notifications
You must be signed in to change notification settings - Fork 576
feat(iOS, Paper, Tabs): add support for tabBarBlurEffect #3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS, Paper, Tabs): add support for tabBarBlurEffect #3033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, leaving one suggestion, but I'm okay with the current version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few questions & remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last comment, but from my side we're good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good ✅
Description
Adds support for
tabBarBlurEffect
on iOS Paper.Closes https://github.com/software-mansion/react-native-screens-labs/issues/271.
Changes
RNSBlurEffectStyle
ScreenStackHeaderConfig
to separate fileRNSBlurEffectStyle
Test code and steps to reproduce
Run example app on Paper, set
tabBarBackgroundColor: 'transparent'
and your favoritetabBarBlurEffect
.Checklist