feat(iOS, Tabs): add support for tabBarMinimizeBehavior #3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As for our discussion about possibility of using a macro, I tested it and it works. I created a ticket for it (https://github.com/software-mansion/react-native-screens-labs/issues/286) because it would probably be cleaner to do it in separate PR and refactor all usages of those checks. |
kkafar
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Looks good!
I've created https://github.com/software-mansion/react-native-screens-labs/issues/305 with an issue report that concerns badge behaviour, but I don't think it is in scope of this ticket. Most likely this is a native bug, however we need to verify that.
kligarski
force-pushed
the
@kligarski/bottom-tabs-minimize-behavior
branch
from
320381d to
02813e7
Compare
kligarski
force-pushed
the
@kligarski/bottom-tabs-minimize-behavior
branch
from
cf6ee6a to
6b923a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
tabBarMinimizeBehavior.Closes https://github.com/software-mansion/react-native-screens-labs/issues/178.
Moved from https://github.com/software-mansion/react-native-screens-labs/pull/214.
Changes
tabBarMinimizeBehaviorTest code and steps to reproduce
Add
tabBarMinimizeBehaviorforBottomTabscomponent, e.g.onScrollDownand check behavior with ScrollView.Checklist