feat: add support for screenId prop allowing for native screen recognition
#2967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Paper the default value of '' wouldn't be translated to nil in native code. Now this is done by addition of custom setter logic (only for Paper).
This is not necessary. On Paper we're fine with getting `undefined` & on Fabric the default will be applied by codegened layer.
kligarski
approved these changes
Jun 6, 2025
| @interface RNSScreenStackView () | ||
|
|
||
| /** | ||
| * \return Arrray with ids of screens owned by this stack. Ids are returned in no particular order. The list might be |
There was a problem hiding this comment.
Suggested change
| * \return Arrray with ids of screens owned by this stack. Ids are returned in no particular order. The list might be | |
| * \return Array with ids of screens owned by this stack. Ids are returned in no particular order. The list might be |
maciekstosio
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
screenIdprop on native side. At the moment we use this value only in JS code.It was brought to my attention, however, that other libs that wanna integrate might want that
to be exposed also on native side.
Changes
Added
screenIdprop & exposed it on both platforms.Test code and steps to reproduce
Any example & add a breakpoint at setter method.
Checklist