fix(iOS): lack of animation on modal replacement #2958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix boils down to removing check whether `changeRootIndex == controllers.count`. It was introduced here: #502. It can be represented differently: `changeRootIndex == controllers.lastIndex + 1` & if I get this correctly it checks whether the modal change in question takes place at the top of view hierarchy, with purpose of not animating non visible changes. It does not take account the replace operation though. In case of replace, the `changeRootIndex == controllers.lastIndex`. Another aspect is that I believe this part of the check is not necessary. If some modal view controller is being dismissed, **all** view controllers above it will also endup dismissed. Therefore, there is no scenario where this check would be useful. Hence, this commit ends up removing the check.
kkafar
changed the title
|
@hirbod you might wanna check this one out in context of the issue we've talked about. |
|
Hi @kkafar, thanks for the tag. I’ll pull the PR and test it. I do think this issue is unrelated though and probably a different one. That said, I love this PR anyway, it makes replacing a modal screen way easier and removes the need for setTimeout and such. |
kligarski
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix boils down to removing check whether
changeRootIndex == controllers.count. It was introduced here:#502.
It can be represented differently:
changeRootIndex == controllers.lastIndex + 1& if I get this correctly it checks whetherthe modal change in question takes place at the top of view hierarchy,
with purpose of not animating non visible changes.
It does not take account the replace operation though. In case of
replace, the
changeRootIndex == controllers.lastIndex.Another aspect is that I believe this part of the check is not
necessary. If some modal view controller is being dismissed, all
view controllers above it will also endup dismissed.
Therefore, there is no scenario where this check would be useful.
Hence, this commit ends up removing the check.
Before & After
bug-recording.mov
fix-recording.mov
Test code and steps to reproduce
I've enhanced
TestModalNavigationwith additional button that allows for modal replacement.I've also tested
TestModalNavigationto make sure other flows keep working.I've also tested #502 - setting
animation: 'none'keeps working for dismissed modals.Checklist