fix(Fabric,iOS): cancel conflicting presses in modals on swipe back gesture #2943
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when looking for `RCTSurfaceTouchHanlder` we've looked only for `RCTSurfaceView`, however on Fabric in modal view hierarchies, the `RCTSurfaceView` can not be reached directly when iterating over UIKit view ancestor chain. However, we do attach `RCTSurfaceTouchHanlder` to every `RNSModalScreen` anyway & we can use that to dispatch / cancel appropriate events.
kligarski
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when looking for
RCTSurfaceTouchHanlderwe've looked onlyfor
RCTSurfaceView, however on Fabric in modal view hierarchies,the
RCTSurfaceViewcan not be reached directly when iteratingover UIKit view ancestor chain. However, we do attach
RCTSurfaceTouchHanlderto everyRNSModalScreenanyway& we can use that to dispatch / cancel appropriate events.
Changes
☝️
Test code and steps to reproduce
Test780should now work on FabricChecklist