Skip to content

fix(iOS): allow to hide the search bar #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2025
Merged

fix(iOS): allow to hide the search bar #2926

merged 5 commits into from
May 19, 2025

Conversation

kligarski
Copy link
Contributor

@kligarski kligarski commented May 16, 2025 •
edited
Loading

Description

Search bar on iOS would not disappear after setting headerSearchBarOptions to undefined. It seems like this issue was present for some time now but somehow it wasn't reported in a seperate issue.

Changes

  • set navItem.searchController to nil if there is no RNSScreenStackHeaderSubviewTypeSearchBar anymore
  • add Test2926 test screen and e2e test

Test code and steps to reproduce

Open Test2926 in Example app, try to hide the search bar.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@kligarski kligarski marked this pull request as ready for review May 16, 2025 14:25
@kligarski kligarski requested a review from kkafar May 16, 2025 14:29
kkafar
kkafar requested changes May 19, 2025
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark. Looks great otherwise, thanks!

@kligarski kligarski requested a review from kkafar May 19, 2025 09:00
kkafar
kkafar approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait for CI & proceed.

@kligarski kligarski merged commit 4a383a9 into main May 19, 2025
8 checks passed
@kligarski kligarski deleted the @kligarski/fix-ios-search-bar-hiding branch May 19, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkafar kkafar kkafar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kligarski @kkafar