fix(iOS): pressables in header not working when hosting screen has modal presentation #2915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not be the final solution, as it just another edge case to the existing code & makes it even more spaghetti-like.
kkafar
added
the
Backport to v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2842
RNSModalScreensends non-zero contentOffsetY to its shadow node. This is wrong, because its content in HostTree is not offset by any means, as there is no associated navigation bar. I do not know, why we do sent non-zero header height there. I guess that this case was overlooked in #2028.Above behaviour leads to discrepancies between HostTree & ShadowTree positions of descendant views, causing problems with pressables.
Changes
Test code and steps to reproduce
Added
Test2915to test exactly this case.Checklist