fix(Android): fix formSheet sliding from top when it contains input with autofocus #2909
+121
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nCallback with empty implementation
Merged
2 tasks
kkafar
requested changes
May 9, 2025
kkafar
approved these changes
May 9, 2025
kligarski
added a commit
that referenced
this pull request
May 20, 2025
…ns input with autofocus (#2911) ## Description Sometimes, formSheet that contains input with autoFocus would not account for the keyboard and would remain behind it. This is because `SheetDelegate` is set as a `OnApplyWindowInsetsListener` when fragment is resumed - this happens after finishing formSheet entering animations (animators impact fragment lifecycle). Sometimes, IME insets were applied before this handler was set. Now, we can use `WindowInsetsAnimationCallback` added in [this PR](#2909). Its `onPrepare` method is called before `onApplyWindowInsets` therefore making it possible to set `OnApplyWindowInsetsListener` in time. ## Changes - change `insetsObserverProxy`'s `listeners` to `HashSet` (we might try to add the same listener multiple times) - override `onPrepare` method in `WindowInsetsAnimationCallback` - change visibility of `SheetDelegate` to `internal` ## Test code and steps to reproduce Open `Test2895` screen in the example app, open & close the formSheet (multiple times). ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On API 36, formSheet that contains input with autoFocus would sometimes slide from the top.
Even though
react-native-screensusedcom.google.android.material:material:1.6.1,InsetsAnimationCallback(which is not present in1.6.1) is called (it probably comes fromcom.google.android.material:material:1.12.0dependency inreact-native-edge-to-edge). This callback interferes with our formSheet entering/closing animations:InsetsAnimationCallback'sonPrepareandonStartare usually incorrect. This has become a significant issue since API 36: for some reason, animation created inScreenStackFragment'sonCreateAnimatoris sometimes incorrecly accounted for in calculatingstartTranslationY. The value becomes negative which means that the formSheet slides from the top.InsetsAnimationCallbackand formSheet animations usesetTranslationYand they are overwriting each other's changes.InsetsAnimationCallback'sonProgressis called just after animation'ssetTranslationYso it takes precedence.We decided to replace the window insets animation callback which is set in
BottomSheetBehavior'sonLayoutChildwith our own implementation. Currently it is empty in order to bring back previous behavior.FormSheet that contains input with autoFocus still does not behave as intented - only rarely it gets expanded with the keyboard. This seems to be a timing issue and needs more investigation. It might be necessary to implement logic in new window insets animation callback.
Fixes #2895.
Changes
com.google.android.material:materialversion to1.12.0BottomSheetBehavior'sInsetsAnimationCallbackwith empty implementationTest2895Test code and steps to reproduce
Open
Test2895screen in the example app and open the formSheet.Checklist