test(e2e, Fabric): add e2e tests for issue/PR examples 648..649 #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check which example screens from issues/PRs can be used in e2e testing for tests
Test648, Test649and implement them if possible for Fabric.Test648
Skipped because we can't check new animation in any meaningful way.
Test649
Test created, only on iOS (
headerLargeTitleis supported only on iOS). It checks ifheaderLargeTitleisn't collapsed when coming back from a screen withoutheaderLargeTitle. I changedTest649screen to match original issue.Changes
Test649Test649to match original issueapps/src/tests/index.tswith the reason for (not) implementing e2e test for itTest code and steps to reproduce
CI
Checklist