chore: bump main examples & lib to use [email protected]
#2825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly reanimated should already work -> @kkafar |
|
I've disabled
The problem is resolved once the We need to get rid of the lib or find a way to fix the issue. |
kkafar
changed the title
FabricExample & lib to use [email protected]
kkafar
changed the title
FabricExample & lib to use [email protected][email protected]
|
I've reported the issue on detox repo here: wix/Detox#4760 |
kkafar
changed the title
[email protected][email protected]
kkafar
added a commit
that referenced
this pull request
Jun 9, 2025
## Description Should be merged after #2825 After 0.80.0-rc.2 we do not require any library code changes. The apps must be updated, but thats it. > [!caution] I'll proceed here, ignoring the detox, so that we can work with recent RN versions in our apps. ## Changes Updated example apps following the upgrade helper. ## Test code and steps to reproduce Apps should build just fine. ## Checklist - [❌] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems that we do not need any library code changes this time.
New architecture
Old architecture
Problems
iOS new arch e2e fails - detox has some issues with reloading the app...
Changes
See commits.
I've mostly followed react native upgrade helper here + I've added
.ruby-versionfiles to our main examples, so that we the lock files generated by different maintainers are the same.Test code and steps to reproduce
Checklist