refactor(iOS): cleanup no. 1 in RNSScreenStackHeaderConfig.updateViewController:withConfig:animated:
#2798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
changed the title
RNSScreenStackHeaderConfig.updateViewController:withConfig:animated:
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method is very hard to read & it is very scary to refactor
since as far as I remember, sometimes even call order matters here.
Therefore, I've decided to split the refactoring process into many small PRs.
This PR improves local variable naming & extracts LTR handling to separate method.
Test code and steps to reproduce
Nothing should change. LTR works as earlier. Can be tested in Example by toggling RTL mode (there is a button for it).
Checklist