fix(CI): change order of events in Fabric iOS events e2e test #2785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed order of events in Fabric iOS events e2e test.
The order of events in this test differs from the Paper version of the same test. When screen is removed after using iOS native back button, native side notifies JS via:
On Fabric, these events are handled in the same order as the order of notifications from the native side. On Paper, this is not the case - onDismissed is executed after two transitionEnd events are already handled. onDismissed is dispatched asynchronously from the native side (it is wrapped in
dispatch_async
!) and this probably delays handling it on JS side but I am not sure of the details why it is dispatched asynchronously.Currently this divergence between architectures seems to not lead to any issues. Just let it be noted & not forgotten.
Changes
Test code and steps to reproduce
Run Fabric iOS CI.
Checklist