fix(Android): keep formSheet selected detent index after fragment reattachment
#2782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SheetDelegate The sheet must be configured in `onCreateView`, because `onAttachedToWindow` is called before `onViewCreated` for reattached fragments and apparently some behaviour code runs, because later configuration is not reflected on screen immediately. I also need the sheet delegate to be created & initialized before the behaviour is configured. Therefore I'm splitting creation & configuration into two phases and also moving configuration code to the delegate to unclutter `ScreenStackFragment`.`
kkafar
force-pushed
the
@kkafar/formsheet-savestate-laststabledetentindex-2
branch
from
d99de24 to
fb95f69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On each fragment reattachment we reconfigure the behaviour, but we do not keep the state.
Each time we use
sheetInitialDetentIndexinstead of the last stable detent index.Changes
This PR moves sheet configuration to
SheetDelegateto declutterScreenStackFragment& uses appropriate value during configuration.Lifecycle of the
SheetDelegateis tied to the fragment, therefore on fragment recreation (not reattachment) the state still will be lost.Recordings
Note
There still is no animation when navigating from
formSheettopushin the same stack, but it is separate issue (already WIP to handle this).Screen.Recording.2025-03-14.at.21.00.12.mov
Screen.Recording.2025-03-14.at.20.58.50.mov
Test code and steps to reproduce
TestFormSheetChecklist