chore(examples): adjust metro config to allow for easier modify-test loop with react-navigation submodule #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/formsheet-push-screen-over-2
branch
from
8d86158 to
922ab1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caution
TODO: Needs to be rebased on top of main, dropping changes from #2736doneI've explained the issue in code comments: metro by default picks up source files from
@react-navigation/xxx/libinstead of ones from@react-navigation/xxx/src.This makes playing with
@react-navigation& testing it harder (even when one just need to add some logs)...Changes
This PR adds a resolver, which explicitly resolves
@react-navigation/xxxpackages imports to the@react-navigation/xxx/src/*implementation.This PR also makes sure the metro block-list works correctly.
Test code and steps to reproduce
No extra tests needed - just example apps should build & load.
You can now add a
console.loginto react-navigation submodule code & it will work!Checklist