fix(Android): prevent crash by properly managing lifecycle of the dimming view #2750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we have a
formSheet
on Android & we navigate to regular push screen on top of it & we go backnavigation.goBack()
the app will crash.
This is because the
ScreenStackFragment
' view will be recreated, but it will reuse existing dimming view, leading to a crash wheninserting this dimming view to a coordinator, because no one never cleared previous parent of it.
Changes
See the code, basically I've ensured that the previous dimming view is invalidated & on fragment view recreation (when it is reattached)
new dimming view is created.
Test code and steps to reproduce
TestFormSheet
Checklist